Crucible
Crucible copied to clipboard
CrucibleMC
[FEATURE] Update mysql connector
We use advanced ban to sync our bans between our modded servers and modern vanilla, however we use mysql 8 as our database as luckyperms and alike also support that version. is it possible to update crucible's db connector.
i've been running my own fork of thermos for two years or so with version mysql:mysql-connector-java:8.0.28 and its stable. there is probably newer versions but i havent looked into those, i think there was something noteworthy after 29 ?
The fork is now archived as i there was just to much issues with the build process and the discovery of crucible. https://github.com/Thorfusion/Thermos
i can make pr if wanted/needed
Is not a common practice for plugins to embed their libs in their jars with a relocated path? Would that not suit your need in this specific case?
Even though, if there is no break this might be possible just like we updated fast utils. But different from fastutils, mysql might be used by many plugins.
The upgrade if from mysql-connector 5.1.14 to 8.0.28 We should be aware of the breaking changes between these two versions, where there a lot? I asked chat GPT here for a summary, it seems a lot '-'
mysql 5 is depricated and insecure so i highly doubt anyone is running it anymore.
yes most plugins has their own libs, like luckperms. but advanced ban does not. most plugins i googled had updated versions for mysql 8, like mysql for essentials extension
i can always compile crucible with mysql 8, just that the other servers running my fork of thermos also uses the mysql feature and probably others also want it
Updating that library seems fine, anything using the connector internal classes internally would be to blame if it breaks. Feel free to make a PR as I don't see any issue updating that.
