Crucible icon indicating copy to clipboard operation
Crucible copied to clipboard

[BUG] Players get kicked when typing into chat using the 1.7.10 Pack

Open LeStegii opened this issue 2 years ago • 4 comments

Describe the bug Players get kicked from the server when typing in chat with The 1.7.10 Pack.

To Reproduce Steps to reproduce the behavior:

  1. Install the 1.7.10 Pack server (https://www.technicpack.net/modpack/the-1710-pack.453902, ArchaicFix removed).
  2. Join the server.
  3. Type something into the chat.

Expected behavior The message should be displayed, and the player should not be kicked.

Logs Clientside logs: https://hastebin.cc/otamaducez.css Serverside logs: [08:10:20] [Server thread/INFO] [net.minecraft.network.NetHandlerPlayServer]: LeStegii lost connection: Internal Exception: java.lang.ArrayIndexOutOfBoundsException: -1

Screenshots /

Additional context Couldn't reproduce the issue with a clean crucible setup with only the HQM mod installed. Works fine on Forge.

Environment (please complete the following information):

  • Crucible Version: This server is running Crucible | https://github.com/CrucibleMC/Crucible | 1.7.10-R0.1-SNAPSHOT | 1.7.10-staging-3aba0ea3 (MC: 1.7.10)
  • Plugins: None
  • Mods: https://gist.github.com/UeberallGebannt/ef77cd9798e1ae9ebca7ccd381bd6675
  • Java Version: JDK8
  • OS: Windows 10 on Client, Linux v33697 5.10.0-23-amd64 # 1 SMP Debian 5.10.179-3 (2023-07-27) x86_64 on server

LeStegii avatar Aug 05 '23 08:08 LeStegii

If needed, this is the line which is throwing an exception on the client inside a buildable fork of HQM: https://github.com/KettleMC-Network/HQM/blob/master/src/main/java/hardcorequesting/network/PacketHandler.java#L224C74-L224C74

LeStegii avatar Aug 05 '23 08:08 LeStegii

I have used HQM myself on a few modpacks. The mod has many different issues. I droped it and started using the less buggy (but still buggy) BetterQuesting.

The HQM is pretty outdated, like from 2015.

The issue here is a PacketDeserialization. To even understand the actual cause of the problem is something 'hard' here.

My suggestion is do not use HQM.

Lets hope someone else has worked a little with HQM and can add some experience on this issue.

EverNife avatar Aug 05 '23 23:08 EverNife

Pretty much impossible as this mod crashes the client and serverside removal doesn't fix anything. It's also definitly an issue on Thermos based servers as Forge works fine but Thermos and its forks don't. Catching the chat with velocity/bungeecord and pasting the message in chat works fine.

Edit: A clean thermos/crucible setup with only HQM installed works fine.

LeStegii avatar Aug 07 '23 12:08 LeStegii

Well, its complicated, we might need someone who understands the PacketSerialization of HQM to fix this T.T

EverNife avatar Aug 07 '23 14:08 EverNife