vertical-tabs-reloaded icon indicating copy to clipboard operation
vertical-tabs-reloaded copied to clipboard

Prevent auto-scrolling with middle click if enabled

Open yaeuge opened this issue 4 years ago • 1 comments

https://github.com/Croydon/vertical-tabs-reloaded/issues/234

yaeuge avatar Jun 27 '20 20:06 yaeuge

Is there any problem?

Detailed steps to reproduce this bug, just in case:

  1. Enable autoscrolling in Firefox settings (Preferences -> General -> Browsing -> Use autoscrolling)
  2. Make sure it is enabled. Open some webpage you can scroll, click on middle mouse button. Round "scrolling icon" should appear, making it possible to scroll page just by moving mouse cursor
  3. In VTR settings check "Close tabs with mouse middle click" option
  4. Open VTR sidebar then open enough tabs for scrollbar to appear. Try to close some tab with middle-click. It is closed, but scrolling icon appears at the same time. Further middle-click closes another tab and hides scrolling icon back

IMO, users do not expect autoscrolling available anywhere except on the webpage itself. This is the only really annoying bug in this extension for me, everything else is just as it should be, thank you for your great work :)

yaeuge avatar Jul 24 '20 11:07 yaeuge

Hi @yaeuge!

Sorry that it took so long and thank you for your contribution!

I will land this in 0.14.0 with some follow-up commits that only prevent auto-scrolling when the option is enabled that lets people close tabs with a middle click

Croydon avatar Aug 04 '23 20:08 Croydon