vertical-tabs-reloaded icon indicating copy to clipboard operation
vertical-tabs-reloaded copied to clipboard

Published 20 hours ago • verified publisher icon Croydon

Middle Click also brings up scrolling popup

Open jimmyjudas opened this issue 4 years ago • 12 comments

When I middle click on a tab to close it, it also brings up the scrolling popup like in https://www.ghacks.net/wp-content/uploads/2014/10/mouse-auto-scroll-chrome.jpg

This doesn't happen when I middle click on a bookmark in the bookmark bar, for example. Is the VTR window not swallowing the middle click event as well as closing the tab?

Thanks

Add-on version: 0.12.1 Firefox version: 70.0 OS + OS-Version: Win 10 10.0.16299 Other tab + user interface related add-ons:

jimmyjudas avatar Nov 04 '19 10:11 jimmyjudas

Thanks for reporting. Behaviour seemed to change with newer Firefox versions

Croydon avatar Nov 04 '19 16:11 Croydon

Super weird, I can't reproduce this anymore.

@jimmyjudas Could you try again?

Croydon avatar Apr 20 '20 07:04 Croydon

BTW. For me middle click does nothing at all. no-op. It doesn't close the tab or bring anything.

I am using Firefox 75.0 on Linux, with MATE / X11. Same with Firefox 74.0.1.

baryluk avatar Apr 21 '20 12:04 baryluk

@baryluk It is an opt-in feature of VTR. Did you enable tab closing on middle click?

Croydon avatar Apr 21 '20 12:04 Croydon

It does the same to me too, on both computers at hand. Win 8.1, FF 75.0, VTR 0.13.0 first computer, Win 10 1809, FF 68.7.0esr 64bit, VTR 0.13.0 the second computer. Has done so since always...

jiri-h avatar Apr 21 '20 20:04 jiri-h

Yeah, it doesn't seem to be doing it for me now either. Currently using Firefox 75.0.

As you said, this didn't always happen and seemed to start around the time I raised the bug. Maybe Firefox introduced a bug then that they've now fixed? I'll keep an eye out for it though and let you know if it starts happening.

jimmyjudas avatar Apr 23 '20 21:04 jimmyjudas

Bug is still present. Surely, middle-button scrolling should be enabled in Firefox settings to reproduce it (Preferences -> General -> Browsing -> Use autoscrolling)

VTR 0.13.1 Firefox 77.0.1 Arch Linux

yaeuge avatar Jun 23 '20 11:06 yaeuge

I've started seeing this again now. It only happens when I have sufficient tabs open to make the panel scrollable. I'm not sure if that was always the case and I just didn't spot the difference between when it was/wasn't happening

Edit: Ah, it looks like @yaeuge has already worked out how to reproduce and created a possible fix

jimmyjudas avatar Nov 18 '20 14:11 jimmyjudas

@jimmyjudas , I'm not familiar with JS, this solution was found at StackOverflow and seems to work. I see no risks in it, though @Croydon ignores it for some reason...

yaeuge avatar Nov 19 '20 17:11 yaeuge

I'm not ignoring it I just don't have a lot of time for VTR currently

I will check out your PR for the next version (which will however not happen in 2020 anymore). It looks good on first sight

Sorry for the time being

Croydon avatar Nov 20 '20 15:11 Croydon

Thanks, Croydon. When you find the time, it'll be much appreciated ☺️

jimmyjudas avatar Nov 20 '20 22:11 jimmyjudas

BTW, switched to Sidebery extension, it is definitely worth trying

yaeuge avatar Jun 08 '21 22:06 yaeuge

@baryluk It is an opt-in feature of VTR. Did you enable tab closing on middle click?

@Croydon

Very late reply. But I probably did not have that enabled. It was must-have feature, and I immediately uninstalled VTR, as without middle click to close tab, it was not usable for me, and I switched to Sidebary years ago.

Why it is opt-in feature? It looks like otherwise middle mouse button does not do anything else. It should be enabled by default to close the tab.

baryluk avatar Sep 03 '23 08:09 baryluk