ember-headless-table icon indicating copy to clipboard operation
ember-headless-table copied to clipboard

Setup turborepo, with injected dependency syncing

Open NullVoxPopuli opened this issue 3 years ago • 5 comments

Supersedes: https://github.com/CrowdStrike/ember-headless-table/pull/44 Inspired by: https://github.com/CrowdStrike/ember-headless-form/pull/52 Presently blocked on: https://github.com/pnpm/pnpm/issues/6088 Unblocking PR to pnpm: https://github.com/pnpm/pnpm/pull/6135 I'm working on that pr to add pnpm sync to the pnpm CLI. -- once merged/released, The hope is that this PR is able to go green.

Once this is proven to work, I'm going to add an ember-apply template for easily applying these changes to any pnpm monorepo (and then add documentation to the v2 addon blueprint for folks that may be interested in adding turbo -- though, there is an argument for using turbo by default, as once pnpm sync exists, we can automate away all the issues with injected dependencies transparently from users)

NullVoxPopuli avatar Feb 25 '23 18:02 NullVoxPopuli

⚠️ No Changeset found

Latest commit: d7a79f6951818e9a1ed859be3e9b7b6b77c416cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 25 '23 18:02 changeset-bot[bot]

What's the status of this?

My understanding is that without it we are not able to make changes in the ember-headless-table package and see those changes reflected in the docs-app and test-app?

I was able to remove the "dependenciesMeta": object from docs-app/package.json and get automatic reloads there as a workaround but removing it from test-app/package.json resulted in all the tests failing because "decorator is not a function"...

vitch avatar Apr 26 '23 11:04 vitch

What's the status of this?

this particular implementation is blocked on my own adding a feature to pnpm (pnpm sync), which requires some spelunking on my part (see linked issues).

Simon and Tony have a strategy in ember-toucan-core and ember-headless-form for fixing this problem via in an in-monorepo extra package.

NullVoxPopuli avatar Apr 26 '23 11:04 NullVoxPopuli

FYI CrowdStrike/ember-headless-form#140 improves the DX around the extra package approach - I think the same would be interesting here on top of #168

vitch avatar May 16 '23 18:05 vitch

Reminder to myself to revisit: https://twitter.com/nullvoxpopuli/status/1662431120149848064

NullVoxPopuli avatar May 29 '23 22:05 NullVoxPopuli