Ace Add type information

Add type information

Open varnerac opened this issue 5 years ago • 4 comments

Type all the things. Minor refactors.

Mar 25 '20 03:03 varnerac

Any thoughts on this?

Mar 31 '20 19:03 varnerac

This is good. Would be good to be able to Run dialyzer against it in travis

Apr 01 '20 07:04 CrowdHailer

@varnerac can you merge the latest master into this branch.

Then have a look if dialyzer passes. https://travis-ci.org/github/CrowdHailer/Ace/pull_requests

I see a few errors on master but wonder if the improved type information on here will clear them up. The errors I have are

lib/ace/governor.ex:37: Function init/1 has no local return
lib/ace/governor.ex:64: Function start_server/1 has no local return

Apr 01 '20 09:04 CrowdHailer

Will do

Apr 02 '20 17:04 varnerac