crowd.dev icon indicating copy to clipboard operation
crowd.dev copied to clipboard

[C-630] Add a description to attributes

Open joanreyero opened this issue 2 years ago • 10 comments

The isHireable attribute coming from GitHub has already confused people a couple of times. We could add a new field to attributes, description, and show it as a Tooltip if it exists


Created via Raycast

From SyncLinear.com | C-630

joanreyero avatar Feb 09 '23 11:02 joanreyero

@joanreyero can you please provide more information and a visual aid for this issue :)

peoray avatar Sep 06 '23 12:09 peoray

cc @yeganathan18, @joanagmaia, can you help here? @joanreyero seems to be busy ;)

peoray avatar Sep 11 '23 08:09 peoray

Hey @peoray, this is a specific attribute we get from Github.

For more context:

  • isHireable is added to the attributes json of a member. Each attribute as a default value and a value per platform (if it exists). So for instance. isHireable would be like this:
isHireable:  {github: false, default: false}

And in the UI it would be displayed like this (we render the default value) Screenshot 2023-09-11 at 18 34 27

This issue asks that the backend adds a description field to the attribute. The frontend would then display it if it existed. Visually, it could be an information icon next to the attribute name, and when hovered, it would show a tooltip with that description.

This ticket would require backend and frontend work

joanagmaia avatar Sep 11 '23 17:09 joanagmaia

Adding extra context here: this ticket does not have a dummy data that could show it from the first time we open the project. (at least that was my case)

a0m0rajab avatar Sep 13 '23 23:09 a0m0rajab

@a0m0rajab Just to make sure I've got this straight, you're indicating that there's no dummy data included in the project for testing purposes, is that right?

skwowet avatar Sep 22 '23 06:09 skwowet

yeah @yeganathan18 do you have suggestions on how to achieve that?

peoray avatar Sep 22 '23 07:09 peoray

Yes, that's right, to test this we need to have an account already connected with GitHub and has users from it.

It would much valuable if we can use it with dummy data .

a0m0rajab avatar Sep 22 '23 09:09 a0m0rajab

Integrating with GitHub helps with the data, but I'm unsure about the feasibility without the envs. Would you mind creating the GitHub envs by yourselves?

If I were in your shoes, I'd manually add the GitHub envs by setting them up through my account and establishing a connection with GitHub. In that way, we could get some data for fixing the issue 🙂

skwowet avatar Sep 22 '23 14:09 skwowet

You are right but I don't have an organisation in GitHub with few people to test, this is the issue here. Otherwise I would have done that

Sent from mobile device


From: Yeganathan S @.> Sent: Friday, September 22, 2023 5:52:39 PM To: CrowdDotDev/crowd.dev @.> Cc: Abdurrahman Rajab @.>; Mention @.> Subject: Re: [CrowdDotDev/crowd.dev] [C-630] Add a description to attributes (Issue #506)

Integrating with GitHub helps with the data, but I'm unsure about the feasibility without the envs. Would you mind creating the GitHub envs by yourselves?

If I were in your shoes, I'd manually add the GitHub envs by setting them up through my account and establishing a connection with GitHub. In that way, we could get some data for fixing the issue 🙂

— Reply to this email directly, view it on GitHubhttps://github.com/CrowdDotDev/crowd.dev/issues/506#issuecomment-1731558896, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AELNMKPYPVWAJUJRDU5PXTLX3WQ3PANCNFSM6AAAAAAUWM4NDU. You are receiving this because you were mentioned.Message ID: @.***>

a0m0rajab avatar Sep 22 '23 15:09 a0m0rajab

@a0m0rajab Sorry for that, I'll check with the team and see if there is a way we could really add some dummy data for testing purposes.

skwowet avatar Sep 23 '23 09:09 skwowet