PushNotificationPlugin icon indicating copy to clipboard operation
PushNotificationPlugin copied to clipboard

Update PNMessagingService.android.cs

Open hajuuk opened this issue 2 years ago • 3 comments

Fix android:export compile issue #175.

hajuuk avatar May 16 '22 05:05 hajuuk

Can someone please review and merge this PR. This should fix the issue of deploying apps on Android 12. @rdelrosario -Thanks

kirankumar4vr avatar Jun 30 '22 16:06 kirankumar4vr

Hi guys! Please review this PR and approve it. This update is required to run Android apps using Target Android API 31. Because all new apps that will use this NuGet will not be available for publication.

Here is the official doc from Microsoft: https://developer.android.com/google/play/requirements/target-sdk#pre12

@rdelrosario, @Px7-941, @vikram-ma, @clintonrocksmith, @Char0394, @rdavisau, @zainniazi, @kpto

AndriyGlodan avatar Aug 08 '22 16:08 AndriyGlodan

@AndriyGlodan I can't do the review until Monday. We are also in the process of Android 12 (SDK 31) migration.

Px7-941 avatar Aug 11 '22 13:08 Px7-941

@Px7-941 / @rdelrosario (or any one with write access), how can we help to make the library support Android 12, Deadline is by November after which we'll not be able to publish newer version of app without targeting Android 12

muhaym avatar Oct 07 '22 13:10 muhaym

@rdelrosario Can you merge the PR?

Px7-941 avatar Oct 11 '22 11:10 Px7-941

@muhaym here is a workaround

<application>
	<receiver android:name="com.google.firebase.iid.FirebaseInstanceIdInternalReceiver" android:exported="false" />
	<receiver android:name="com.google.firebase.iid.FirebaseInstanceIdReceiver" android:exported="true" android:permission="com.google.android.c2dm.permission.SEND">
		<intent-filter>
			<action android:name="com.google.android.c2dm.intent.RECEIVE" />
			<action android:name="com.google.android.c2dm.intent.REGISTRATION" />
			<category android:name="${applicationId}" />
		</intent-filter>
	</receiver>
	<service android:name="crc640921eac73192168e.PNMessagingService" android:exported="true" tools:node="merge">
		<intent-filter>
			<action android:name="com.google.firebase.MESSAGING_EVENT" />
		</intent-filter>
	</service>
</application>

you can add the missing export flags with the manifest merge solution.

Px7-941 avatar Oct 11 '22 12:10 Px7-941