CrossGeeks
Make Android OnReceived condition virtual, fix UnsubscribeAll ios Bug and Update to new firebase sdk
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
:arrow_heading_down: What is the current behavior?
The condition to skip displaying a notification with android is confusing/complicated: https://github.com/CrossGeeks/FirebasePushNotificationPlugin/blob/d86266a9f45687b418f5f1e69c348681d1ff6e27/Plugin.FirebasePushNotification/DefaultPushNotificationHandler.android.cs#L151 More infos: https://github.com/CrossGeeks/FirebasePushNotificationPlugin/issues/434
:new: What is the new behavior (if this is a feature change)?
With this change it is possible to implement a custom condition or simple skip the condition (return false). Just override the virtual method.
:boom: Does this PR introduce a breaking change?
No.
:bug: Recommendations for testing
:memo: Links to relevant issues/docs
:thinking: Checklist before submitting
- [x] All projects build
- [x] Follows style guide lines
- [ ] Relevant documentation was updated
- [ ] Rebased onto current develop
Fixed a bug in FirebasePushNotificationManager.ios.cs. You loop thru currentTopics array in UnsubscribeAll and in the loop you remove items in currentTopics. Which results in an incomplete Unsubscribe operation.
Hi @rdelrosario, could you merge this and release a new version? Thank you very much!
@rdelrosario can we expect this change to be merged before June 2024? @AlleSchonWeg thanks for your effort. We'd need an upgrade of this package for our old xamarin apps - they're probably not migrated to .NET MAUI by June 2024...
Hi @thomasgalliker , i think this package will still work. I accidently pushed the last commits to this pull request. I only want to test the new bindings project with XF. And it works. If you want you can take my changes to your new plugin. It would we great if your plugin will also run with XF apps.
Ok cool. Its a nightmare to have to support .net maui and XF in one single project. I would rather publish a new nuget for xf (temporarily) until we have migrated to maui. Yet another nuget, I know what you think. The best solution would be to publish this changes here but it look like this plugin is no longer maintained….