Attila Lakatos comments

Results 79 comments of


                                            Attila Lakatos

Drop CAP_IPC_LOCK capability

Hello, sorry for the late reply but I was in a pretty bad health condition for ~2 weeks. I will look into it and provide you more details soon.

ossl netstream driver: allow ephemeral Diffie-Hellman key exchange

> I am sorry I must have overseen this PR. Could I take over the PR and rebase it on the current master? Sure. I appreciate the help.

Race issue can happen between action.resumeInterval and action.resumeIntervalMax

I am reopening the issue. I thought that the PR fixed this one as well but it seems like these are two separate bugs.

clarify the exact semantics of comments in the rules config

Everything after the "#" symbol until the end of the line is treated as a comment if and only if the line starts with that particular symbol or has at...

Add "--version" option to the usbguard CLI

Hi Sebastian, > Hi @Cropi, > > I had a quick look through the changes and also inspected the output locally: > > ``` > # ./usbguard --version > usbguard...

Add option --version

I agree that this could come in handy when debugging future issues.

ruleset: detect integer overflow of the ID and bail out

Hi @muelli, Thanks for the PR! I think it would be better to check if the new device ID is already assigned to an existing device. With this approach, we...

needs way to allow/blow devices interactively

For the first part of the request, this has been delivered in https://github.com/Cropi/usbguard-notifier/pull/71. And the second part: I agree that it's not feasible to see ~15 or more notifications popping...

Fix passing the value to EscapeChar.

I see that in `doGetChar`, the handler function `setParserControlCharacterEscapePrefix` is called with the appropriate escape character, which is type of `uchar`. However, `setParserControlCharacterEscapePrefix` expects it to be `uchar *`, that's...

rsyslogd and journald behavior

I am not sure if I understood your requirements but will try to help. If you want to forward all messages to a syslog server then you might want to...