Avrae-Customizations icon indicating copy to clipboard operation
Avrae-Customizations copied to clipboard

[DRAFT] Make scast work with metamagic adept

Open etriebe opened this issue 1 year ago • 1 comments

What Alias/Snippet is this for?

Update scast to work with a different custom counter for meta magic adept

Summary

Fix #36

Checklist

PR Type

  • [x] This PR is a code change that implements a feature request.
  • [ ] This PR fixes an issue.
  • [ ] This PR adds a new feature that is not an open feature request.
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

Other

  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] If code changes were made then they have been tested.
  • [ ] I have updated the documentation to reflect the changes.
  • [x] I properly commented my code where appropriate

etriebe avatar Jul 18 '23 22:07 etriebe

Questions: How do I test this? Is there a way to get avrae to test with a PR? Do I need to unsubscribe from the existing collection and make my own? This is my first time modifying a github repo and creating a PR for an alias. What does the cc_out line do on line 71? I'm attempting to make this work with arrays, since technically someone could have metamagic and be metamagic adept (IIRC). If that can't be the case, I'll do an either-or situation.

@Croebh

etriebe avatar Jul 18 '23 22:07 etriebe