Cyrille C.

Results 65 comments of Cyrille C.

## Reproduce the issue :heavy_multiplication_x: Has I don't have [minimalistblogger](https://superbthemes.com/minimalistblogger/) I cannot reproduce the issue. However from the informations you gave me I can clearly see that the problem comes...

> We will add a checkbox after this line > > https://github.com/wp-media/wp-rocket/blob/0918f5017d02fcc9d438c6419af5e891a589d848/views/deactivation-intent/form.php#L49 > and set a `checked` attribute in it to be checked by default with name attribute maybe `export_settings`...

> Looking at the tests run on GH there is still a lot if popping-up, it seems to happen even outside of the tests themselves? @Tabrisrp Yes problem is this...

@Tabrisrp look like guarding the table fix warnings outside the tests: https://github.com/wp-media/wp-rocket/runs/8074979289?check_suite_focus=true

## Scope a solution A quick fix is to add the referrer to that action. For that we can add the following logic to the [renderer](https://github.com/wp-media/wp-rocket/blob/60b76bc8bc9a366bf5b9644894df8203bba103fd/inc/classes/class-abstract-render.php#L128): ```php if ( !...

> @MathieuLamiot @jeawhanlee Which hooks are we talking about here? @piotrbak all RUCSS hooks that where here to configure the queue are renamed to SaaS prefix which gonna break our...

> @piotrbak Is this OK to proceed this way? Also, this might impact the support team and their tooling. @MathieuLamiot with the current implementation the support will be already impacted....

> @CrochetFeve0251 But deprecating them would mean that the currently used filters would still work, no? @piotrbak yes now they are broken. The idea is to add a bridge between...

> @jeawhanlee @CrochetFeve0251 This is what I want to clarify here. We (@piotrbak and myself) don't have exact visibility on what the current implementation is, so we can't know what...

@MathieuLamiot if we reuse the same code basis in the 3.16 as before this will be needed