RMS icon indicating copy to clipboard operation
RMS copied to clipboard

Add FOV check for platepar

Open dvida opened this issue 1 year ago • 2 comments

This pull request adds a FOV check for the platepar in the Reprocess.py file. The check ensures that the FOV in the platepar is within a factor of two of the FOV in the config file. If the FOV ratio is smaller than 0.5 or greater than 2, the platepar is not used. This check helps to ensure that the platepar and config file are compatible before using the platepar for further processing.

Example of when this is needed: https://globalmeteornetwork.org/weblog/US/US003F/US003F_20240924_021434_064110_detected/

dvida avatar Sep 25 '24 22:09 dvida

I wonder if could be caused by these lines: https://github.com/CroatianMeteorNetwork/RMS/blob/cdec45adf64585586a66399b9336161c28956af8/RMS/Astrometry/CyFunctions.pyx#L1151-L1153

https://github.com/CroatianMeteorNetwork/RMS/blob/cdec45adf64585586a66399b9336161c28956af8/RMS/Astrometry/CyFunctions.pyx#L1509-L1511

I got rid of % in my code without ill-effect and I don't seem to get these runaway issues.

Cybis320 avatar Sep 30 '24 00:09 Cybis320

If we have a set of files that reliably goes rogue, we could try commenting out the above snippets to see what happens. Can we reproduce the problem?

Cybis320 avatar Sep 30 '24 01:09 Cybis320