CroatianMeteorNetwork
Define .config Path Relative to RMS Root
Currently, RMS can only function when the working directory is the RMS root directory because the .config path is defined relative to the working directory in the .pyxbld files. This is inconvenient when, for instance, we want to use RMS functions in other projects. This PR defines the `.config' path relative to the RMS root directory regardless of the actual working directory path.
it seems so. In multi-station configuration, the .config path is passed as parameter -c, which most of RMS functions understand.
it seems so. In multi-station configuration, the .config path is passed as parameter -c, which most of RMS functions understand.
True. And I guess the pyxbld stuff already reads from the default config in these situations so at least this will ensure it is consistent.
No. Actually, in multicam the pyxbld files are still grabbing the config file from the working directory not the station’s.
On Sep 23, 2024, at 8:10 AM, Mark McIntyre @.***> wrote: @markmac99 commented on this pull request.
Is this going to conflict wth the multicamera build, which locates the config file in a camera-specific folder?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
To clarify, the PR does not affect how multicam or single cam operate.
Currently, both single and multicam setups use the built parameters specified in the config file located in the working directory, no matter what other config file might be specified at launch.
The PR only change is that the built parameters will be coming from the config file in the RMS root directory not the working directory.
Then, there is no problem with the single user multicam. The current workflow starts with creating the single camera at standard location, and then cloning the .config for multicam. The build info remains untouched.
Dne po 23. 9. 2024 18:20 uživatel Luc Busquin @.***> napsal:
To clarify, the PR does not affect how multicam or single cam operate.
Currently, both single and multicam setups use the built parameters specified in the config file located in the working directory, no matter what other config file might be specified at launch.
The PR only change is that the built parameters will be coming from the config file in the RMS root directory not the working directory.
— Reply to this email directly, view it on GitHub https://github.com/CroatianMeteorNetwork/RMS/pull/424#issuecomment-2368901641, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIU5B2YINCPMVA6TU57KUDZYBEUPAVCNFSM6AAAAABORJEI3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYHEYDCNRUGE . You are receiving this because you commented.Message ID: @.***>
Without the PR, the pyxbld files use a hardcoded ./.config. It causes an error If any RMS module is accessed when the working directory does not contain a .config file.
The use case for the PR is when trying to work with RMS modules outside our standard environment. The PR has no impact on current single or multicam operations.
Note that currently the build parameters in the station's config files on multicam are ignored. Only the working directory config build params are used. This is fine as it would be nonsensical to have different build parameters for different cameras. This PR would simply point to the RMS root config for the build params. Currently the same thing is achieved as we are forced to manually set the working directory to the RMS root directory.