LaravelShoppingcart icon indicating copy to clipboard operation
LaravelShoppingcart copied to clipboard

Laravel 5.8, Testing and more Features

Open bumbummen99 opened this issue 5 years ago • 4 comments

As this was requested, i want to merge back my version of the Package containing a lot of open Pull Requests from here and some other additions i have made. The summary of additions can be obtained from the commit history and/or the appropiate PR or Issue on this repository directly but i am going to provide a complete list if needed. I just want to apologize in advance for the many fail commits.

Features:

  • Updated and tested for Laravel 5.7 and 5.8
  • Refactored the compatible software in composer.json
  • Added and improved tests. Also added tests per issue
  • Added weight feature
  • Here and there improvements

Included PR's:

  • https://github.com/Crinsane/LaravelShoppingcart/pull/502
  • https://github.com/Crinsane/LaravelShoppingcart/pull/350
  • https://github.com/Crinsane/LaravelShoppingcart/pull/349
  • https://github.com/Crinsane/LaravelShoppingcart/pull/478
  • https://github.com/Crinsane/LaravelShoppingcart/pull/509
  • https://github.com/Crinsane/LaravelShoppingcart/pull/452

bumbummen99 avatar Jun 26 '19 16:06 bumbummen99

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f460ab7). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #571   +/-   ##
=======================================
  Coverage          ?   100%           
  Complexity        ?    136           
=======================================
  Files             ?      5           
  Lines             ?    356           
  Branches          ?      0           
=======================================
  Hits              ?    356           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ Complexity Δ
src/Config/cart.php 100% <ø> (ø) 0 <0> (?)
src/CartItemOptions.php 100% <ø> (ø) 1 <0> (?)
src/CartItem.php 100% <100%> (ø) 51 <13> (?)
src/ShoppingcartServiceProvider.php 100% <100%> (ø) 2 <0> (?)
src/Cart.php 100% <100%> (ø) 82 <36> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f460ab7...ce5c145. Read the comment docs.

codecov-io avatar Jun 26 '19 16:06 codecov-io

This is a must PR @Crinsane !

jsdecena avatar Jul 06 '19 07:07 jsdecena

is this going to merge soon? can't install even on dev-master.

nasrulhazim avatar Jul 10 '19 02:07 nasrulhazim

some of this is already has PR in here https://github.com/Crinsane/LaravelShoppingcart/pull/550

lloricode avatar Jul 17 '19 00:07 lloricode