Iridium icon indicating copy to clipboard operation
Iridium copied to clipboard

Published 20 hours ago • verified publisher icon Crepe-Inc

Add full support of GOOD format

Open Escheee opened this issue 2 years ago • 3 comments

Decode AvatarDataNotify and PlayerStoreNotify packet

Escheee avatar Jun 04 '22 12:06 Escheee

Hi! Please remove the binary dump filesystem-related functionality from this pull request, it hurts performance a lot. GOOD stuff is good, though.

Also, I think it would be prudent to use the data submodule that is already in the root of the project instead of doing the source folder - it's a leftover of initial code. Also have handling for it in case it's missing.

SlotPrior is redundant. Check out FRZ.rels.

Algoinde avatar Jun 04 '22 13:06 Algoinde

GOOD is indeed good :trollface:

memetrollsXD avatar Jun 04 '22 14:06 memetrollsXD

Hi! Please remove the binary dump filesystem-related functionality from this pull request, it hurts performance a lot. GOOD stuff is good, though.

Also, I think it would be prudent to use the data submodule that is already in the root of the project instead of doing the source folder - it's a leftover of initial code. Also have handling for it in case it's missing.

SlotPrior is redundant. Check out FRZ.rels.

Done

Escheee avatar Jun 09 '22 03:06 Escheee