Crementif
Add Apex Legends Profile
I felt like my last Apex Legends PR was a bit messy so I wanted to start from a clean slate.
Instead of putting from a resources.json file, I decided to just put all the resources in the profile instead, eliminating the need to do a disk read every time the function is called.
Nice work! Did you check if you could host these image files on the GitHub repository itself so that we don't have to risk relying on an image hosting website? I just feel that these websites are bound to shut down eventually so it is a bit of a risk. Alternatively, if we're gonna have profile specific IDs anyway then we could just upload them to the Discord Developer Hub.
Hmm, it seems like you can use links in the repo for the images on the rich presence., but the only thing that would not be great if someone were to use this and would have to clone the repo, having to download all the images for these games that they probably don't play.
I was thinking of maybe keeping them in a separate repo, if ever we were to go down that path.
If we're going to have profile specific IDs, we can definitely just put assets in the developer hub, but that means that we're limited with 300 assets. Not that a presence would need to have 300 assets used, but if it does, we would need to find a workaround haha
Yeah, that is indeed a valid concern, especially if we're gonna have many games or even a few games that have a ton of images. But lets worry about that once we get there!