Larry Garfield

Spaces instead of tabs goes back to PSR-2, not PSR-12. PSR-2 had a lot of problems, most notably that decisions were made based purely on a naive survey rather than...

Erf. This is a PHP limitation. `readonly` properties are private-write, and you cannot change that. That means you cannot write to them even from a child class. IMO this is...

Closing, as this is not something that can be solved by Serde.

OK, I've looked into this a bit and the fix is... annoying. The first issue is a couple of `isset()` calls that should be `array_key_exists()`. That's easy enough to fix....

Interesting! I can see where Enums make sense here, conceptually. If we're going to go that far, however, does it make sense to go even farther? ```php enum Version: string...

Well, I'm still undecided about how the enums should be treated. If we go with the "enum defines everything" approach, then it becomes as simple as: ```php #[EnumMap(Version::class)] ``` However,...

(Thinking aloud...) Hm. I'm not a big fan of option 3, because it requires manually doing all the enum->value stuff manually. It still feels like if you're using an enum,...

The problem here is that we will never be able to deserialize an object to mixed, as there's no indication of what the type is. Serialization is possible, but you're...

On a lark, try the `master` branch. I pushed some cleanup yesterday that may have made objects work by accident. I just didn't write tests for it yet to be...

OK, tested it, and it won't work. The problem is the refactored approach sends the value to serialize back through the serializer, which means the same object goes through Serializer::serialize()...