Creit-Tech
Feat: Ledger Wallet Integration
What kind of change does this PR introduce?
This PR introduces a new feature.
What is the current behavior?
The kit currently does not support Ledger Wallet. This PR solves #10.
What is the new behavior (if this is a feature change)?
The Stellar Wallets Kit will now support Ledger Wallet. For that the Kit devs docs were followed, to make sure the appropriate methods were implemented.
This also adds some packages such as @ledgerhq/hw-transport-node-hid to manage the hw wallet connection, the stellar-sdk, and the @ledgerhq/hw-app-str to use the stellar app.
Hi @lindsaymoralesb, is there a reason why you are using the BTC transport even doe this is a Stellar kit? Also the signTx function doesn't receive an Stellar Transaction, instead it gets some parameters the kit needs to handle in order to pass it to the Ledger.
Keep in mind that ledgers have limits in how long the string to hash they can handle, so in such cases you should switch between a regular transaction and a hash transaction.
Hi! @earrietadev You are right, I made a mistake with the BTC. Now I refactored the code to use the correct packages and also comply with the devs documentation regarding the methods to implement and their correct params and return values.
Now the PR is ready for review!