Creators-of-Create
When I am trying to browse the "Filling by spout" tab in JEI(Farmers' Delight installed), the game crashed.
Description
As the title suggests.
After removing other mods, it was found that only when Farmer's Delight, Create, and JEI are all present, browsing the "Filling the spout" tab and scrolling to the third page will trigger a crash.
I'm not sure if this is an issue with JEI or Farmers' Delight or this mod. If it's JEI's problem, sorry to bother you.
Game Information, Mod Version Number, and Error Log are as follows.
Context
Game version: 1.21.1
Mod List:
create-1.21.1-6.0.8.jar |Create |create |6.0.8 |Manifest: NOSIGNATURE FarmersDelight-1.21.1-1.2.9.jar |Farmer's Delight |farmersdelight |1.2.9 |Manifest: NOSIGNATURE flywheel-neoforge-1.21.1-1.0.5.jar |Flywheel |flywheel |1.0.5 |Manifest: NOSIGNATURE jei-1.21.1-neoforge-19.25.0.325.jar |Just Enough Items |jei |19.25.0.325 |Manifest: NOSIGNATURE client-1.21.1-20240808.144430-srg.jar |Minecraft |minecraft |1.21.1 |Manifest: a1:d4:5e:04:4f:d3:d6:e0:7b:37:97:cf:77:b0:de:ad:4a:47:ce:8c:96:49:5f:0a:cf:8c:ae:b2:6d:4b:8a:3f neoforge-21.1.214-universal.jar |NeoForge |neoforge |21.1.214 |Manifest: NOSIGNATURE Ponder-NeoForge-1.21.1-1.0.64.jar |Ponder |ponder |1.0.64 |Manifest: NOSIGNATURE
Crash Report
This seems related to the https://github.com/vectorwing/FarmersDelight/blob/1.21/src/main/resources/data/farmersdelight/recipe/integration/create/filling/chocolate_pie.json recipe provided by Farmer's Delight, which is using the pre-6.0.7 fluid syntax (though if I understand 58876e2b135e0eab86699670af11aa4adadebbf7 correctly that was supposed to still be supported)
This seems related to the https://github.com/vectorwing/FarmersDelight/blob/1.21/src/main/resources/data/farmersdelight/recipe/integration/create/filling/chocolate_pie.json recipe provided by Farmer's Delight, which is using the pre-6.0.7 fluid syntax (though if I understand 58876e2 correctly that was supposed to still be supported)
the issue is c:chocolates
should be c:chocolate
after fixing it:
Ah yeah that'd do it. This https://github.com/Creators-of-Create/Create/commit/bda4d6d65049d2d1759c62168f390ce8498c435d was ultimately caused on our end by switching to what is arguably the correct (singular) tag, and the recipe should definitely be fixed on the end of Farmer's Delight, but these recipes crashing is a bit of a regression of #6625 so keeping this open.
Ah yeah that'd do it. This bda4d6d was ultimately caused on our end by switching to what is arguably the correct (singular) tag, and the recipe should definitely be fixed on the end of Farmer's Delight, but these recipes crashing is a bit of a regression of #6625 so keeping this open.
Technically, it's a valid recipe, empty tags don't make a recipe invalid, it's just that it causes a crash in the JEI compat later down the line, i'd also argue here that JEI should catch the rendering exception and display it rather then straight up crash here (EMI handles it like this)
https://github.com/mezz/JustEnoughItems/issues/4180#issuecomment-3586357175 JEI fixed the crash problem yesterday. If you update to the version above [19.25.1.331] , the game won't crash any more.
