Create
Create copied to clipboard
Fix filter inconsistencies when filtering filters
- Fixes package filters with an empty address string still accepting package filters.
- Fixes attribute filters with empty attribute lists always and only accepting attribute filters, irrespective of whitelist mode (doesn't match traditional definitions of 'matches any', 'matches all', and 'not matches any' which would result in nothing, everything, everything)
- Fixes - #5017 by undoing 'Fixed Filters and Attribute Filters not stacking with unmodified, equivalent stacks' from ffa85dc8891362ce9baa8e84bd89326be5594e95, because that also led to:
- Fixes empty list filters on allow mode and ignore data (per the allow-mode summary, this should reject everything) still accepting list filters: in the existing code for FilterItemStack, there is a meaningful difference between 'stack has no nbt' and 'stack has the default value as nbt', but the latter is currently unobtainable: https://github.com/Creators-of-Create/Create/blob/880ec94f86cade553f7b69a0391aaf02e2490949/src/main/java/com/simibubi/create/content/logistics/filter/FilterItemStack.java#L26-L33