Create icon indicating copy to clipboard operation
Create copied to clipboard

Portable Drill for Create: Stuff & Additions crashes when Shift Clicking

Open null15 opened this issue 8 months ago • 4 comments

Context

Steps to reproduce:

  1. Craft a Portable Drill.
  2. Shift to display more information about said item.
  3. If you do not crash, then enchant it with Digging and try again.

Crash Report

https://mclo.gs/D1Y6CZB

null15 avatar Apr 24 '25 11:04 null15

I want to reiterate, this is a very critical bug because it completely makes the character model invisible, cursor and among other funky broken things. My bed also ended up becoming invisible, but I can still sleep on it. Functionally, everything works as long as you don't shift to display information about the item to cause the crash. But character not rendering, cursor not rendering, some blocks like bed not rendering, it is quite critical.

null15 avatar Apr 24 '25 12:04 null15

Enchant Icon seems to be unconditionally swapping the item model for any (maybe only enchanted?) items when its hotkey is pressed. (Also shift apparently).

Create logically assumes that the model for an item using CustomRenderedItemModelRenderer is in fact a CustomRenderedItemModel. Checking whether that assumptions holds might be possible but I’m not sure if there is a sensible default in that case.

Edit: I don’t see how the other stuff is related, either the game crashes and you cannot play on without restarting, or you’re using not enough crashes and that is not guaranteed to leave the game in a proper state to continue playing.

VoidLeech avatar Apr 24 '25 12:04 VoidLeech

Enchant Icon seems to be unconditionally swapping the item model for any (maybe only enchanted?) items when its hotkey is pressed. (Also shift apparently).

Create logically assumes that the model for an item using CustomRenderedItemModelRenderer is in fact a CustomRenderedItemModel. Checking whether that assumptions holds might be possible but I’m not sure if there is a sensible default in that case.

Edit: I don’t see how the other stuff is related, either the game crashes and you cannot play on without restarting, or you’re using not enough crashes and that is not guaranteed to leave the game in a proper state to continue playing.

I talked with someone else and they said about the same thing as you:

It refers to the enchantment - the "enchanticon" is causing some kind of rendering issue So maybe an issue/conflict with Embeddium/Oculus FancyMenu is mentioned, too

I'll be removing EnchantIcon and then test, and if I still crash I'll go ahead and test removing FancyMenu as well. But I think you're both on the right track, enchanticon might be the cause issue here. Will post an update soon.

null15 avatar Apr 24 '25 14:04 null15

It was in fact EnchantIcon causing the issue

null15 avatar Apr 24 '25 14:04 null15

EnchantIcon would need to fix this

IThundxr avatar May 05 '25 12:05 IThundxr