Create
Create copied to clipboard
Creators-of-Create
Fix concurrency issue in Creative Tabs System
Fixes #6222
Forge's parallel/concurrent mod loading causes multiple mods to insert into this hashmap at the same time, switching to a concurrent hashmap will make this thread safe.
4f4b21c0a5d67379214e78f72781dfbc3e2696b4 should probably be reverted.
As I mentioned here, using HashMap over IdentityHashMap places most of Create's blocks in the palette tab for some reason, and the same is true with ConcurrentHashMap:
While with Collections.synchronizedMap(IdentityHashMap) the tabs remain as they are:
4f4b21c should probably be reverted. As I mentioned here, using HashMap over IdentityHashMap places most of Create's blocks in the palette tab for some reason, and the same is true with ConcurrentHashMap:
While with Collections.synchronizedMap(IdentityHashMap) the tabs remain as they are:
using a synchronizedMap means that all other threads trying to add to the map will be sent into a queue to add into it iirc, this will likely increase loading times by a noticeable amount if many mods are using CreateRegistrate. A solution to this would be extending CHM and basically implementing a IHM ontop of that so you'd have a CIHM, i'll have to take a look at doing this when i've got a bit more time, for now i'll turn this into a draft.
it'll be fine it appears, oracles docs say that a sync map will just queue inserts which should be fine
So what I understand this is create issue, not the addons?
The issue lies in create but only occurs when multiple addons using CreateRegistrate are installed and when forge's parallel mod loading loads create or multiple addon(s) at the same time
Are we getting Create 0.5.1 patch G now? :]
Probably. @IThundxr could you please also throw in a fix for #6421 before you release the update? Not sure if you've seen the issue yet.
i forked the project and built from the branch, still noticed no changes from the regular jar on curseforge. The bug only happens when you log directly from a server and gets fixed if u go on SP first. this is truly annoying and a hotfix would be the best thing to do as this is a BIG issue
i forked the project and built from the branch, still noticed no changes from the regular jar on curseforge. The bug only happens when you log directly from a server and gets fixed if u go on SP first. this is truly annoying and a hotfix would be the best thing to do as this is a BIG issue
the issue happens with parallel mod loading, joining a single player world or not changes nothing.
Hey @IThundxr could you please push an update with this patch or maybe release a dev build that includes it? This issue is really frustrating and having be gone would be nice :)
Hey @IThundxr could you please push an update with this patch or maybe release a dev build that includes it? This issue is really frustrating and having be gone would be nice :)
He released a fix for 1.20 in the form of a jar file, update with the fix will be... at some point. link below. https://nextcloud.ithundxr.dev/s/KAjGmnpj7bczoyr
He released a fix for 1.20 in the form of a jar file, update with the fix will be... at some point. link below. https://nextcloud.ithundxr.dev/s/KAjGmnpj7bczoyr
Ah, thank you very much, didn't know he released smth :)
