Create icon indicating copy to clipboard operation
Create copied to clipboard

Make hardcoded basin checks use tags (1.18.2)

Open StormDragon-64 opened this issue 1 year ago • 1 comments

This simply changes every check for AllBlocks.BASIN to use a new tag for basins so that way it isn't hardcoded to only work with Create’s basin block. This allows addons to add their own basin with the full functionality of the original basin without having to resort to make a mixin for every file that has this check, and instead can simply add their own basin to the tag.

StormDragon-64 avatar Feb 24 '24 02:02 StormDragon-64

These are all the problems that would currently require mixins to fix that would be fixed by this PR (if the custom basin is added to the basin tag).

StormDragon-64 avatar Mar 24 '24 19:03 StormDragon-64

Thanks for the PR! This has been implemented in 8add39d24d7452bacd85ddb57a2f841d21e0d661 Most basin machinery expects a Basin blockentity so that felt more appropriate here

simibubi avatar Jul 25 '24 14:07 simibubi