Create
Create copied to clipboard
fix deployers placing blocks when they shouldn't
This should fix #5674. I don't know if this is the correct way to do things, but before this fix, the deployer could right click blocks and therefore place them directly in front of itself.
This looks like the right place to fix the issue. However, the proposed fix will prevent deployers from placing blocks into source liquid blocks, since they are instance of BlockItem but not AirBlock. It would be preferable to add a check for whether (world.getBlockState(targetPos).getBlock() is an instance of BlockLiquid or IFluidBlock, in addition to Air.
Thanks for your suggestion! I implemented it with
world.getBlockState(targetPos).getMaterial().isLiquid()
because your exact suggestion did not work for me.
Can we have this merged into the next release?
Thanks for the PR Looks like this happened as a result of another PR fixing a different set of issues. Further investigation might be useful if it leads to both issues being solved. For now the revert is taking priority