ngx-tree-select icon indicating copy to clipboard operation
ngx-tree-select copied to clipboard

ngx-tree-select angular 10 issue

Open telishreyas10 opened this issue 4 years ago • 19 comments

Hello,

I have migrated my angular 9 project to angular 10. After completing all necessary migration steps, I tried to do ng serve on my project and I started to get this error:

**ERROR in node_modules/ngx-tree-select/src/module.d.ts:11:56 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).

FYI: while migration from 9 to 10 I have used --force flag along with ng update

telishreyas10 avatar Jul 08 '20 12:07 telishreyas10

Facing same issue after migrating project angular 9 to angular 10

02jaysenghani avatar Aug 13 '20 14:08 02jaysenghani

@Crazyht I do hope this can be fixed as your module is exactly what I need, but we have already migrated our projects to Angular 10

AcidSlide avatar Nov 06 '20 19:11 AcidSlide

Looks like this project is dead in the waters 😩

AcidSlide avatar Dec 02 '20 23:12 AcidSlide

Guys, i fixed the error in #204 . Basically the ModulesWithProviders now requires a type, you can do it locally, as a temporary workaround, but i need the pull request to be merged and a new build to fix it for good :\

Nokhoneryu avatar Feb 04 '21 16:02 Nokhoneryu

This issue is fixed by #204 and can now be closed

Nokhoneryu avatar Feb 05 '21 17:02 Nokhoneryu

This issue is fixed by #204 and can now be closed

This is so great to hear.. so we will just wait for the update via NPM.. thanks

AcidSlide avatar Feb 05 '21 17:02 AcidSlide

I closed this issue only when build server want compile changes :P For the moment I get some error

Crazyht avatar Feb 05 '21 19:02 Crazyht

I've seen the error in the build, it seems that in the actual angular version of this project, ModuleWithProviders must have a generic type, and in angular 10 must have an explicit type (generally the Module to which it refers to)... I thought it was overridable in previous versions, but i was wrong... We must overhaul the project dependencies to angular 10+ in order to build properly... I'm working on that currently

Nokhoneryu avatar Feb 05 '21 19:02 Nokhoneryu

any updates on this? :)

AcidSlide avatar Feb 11 '21 00:02 AcidSlide

Kinda... I've been trying to bring the app to Angular 11, however, since the app hasn't been updated in a while, i'm in a peer deps hell, where quite a few don't have angular 11 compatible versions...

Nokhoneryu avatar Feb 11 '21 11:02 Nokhoneryu

Hi all i have fixed this

see the updated code


export declare class NgxTreeSelectModule {
    static forRoot(options: TreeSelectDefaultOptions): ModuleWithProviders<NgxTreeSelectModule>;
    static ɵmod: ɵngcc0.ɵɵNgModuleDefWithMeta<NgxTreeSelectModule, [typeof ɵngcc1.TreeSelectComponent, typeof ɵngcc2.TreeSelectItemComponent, typeof ɵngcc3.OffClickDirective, typeof ɵngcc4.ItemPipe], [typeof ɵngcc5.CommonModule, typeof ɵngcc6.FormsModule], [typeof ɵngcc1.TreeSelectComponent]>;
    static ɵinj: ɵngcc0.ɵɵInjectorDef<NgxTreeSelectModule>;
}

Sakthivelv avatar Feb 16 '21 11:02 Sakthivelv

When do you plan to update NPM?

mobilestar1 avatar Mar 02 '21 15:03 mobilestar1

We are in the middle of a migration project from Angular 5 to 11 and we wish to continue using ngx-tree-select but for that we need this fix to be packaged and available through NPM. Do you have an idea when we can expect that to happen?

LoGA80 avatar Mar 02 '21 16:03 LoGA80

Any update on this?

AcidSlide avatar Mar 13 '21 04:03 AcidSlide

Any updates on this fix?

vatsal2210 avatar Apr 22 '21 21:04 vatsal2210

Is this still being updated?? Or a better question is... will this still be fixed for higher Angular versions? There's already even Angular 12 hahahahaha

AcidSlide avatar May 24 '21 21:05 AcidSlide

Hi, hope this will be updated on npm. @Crazyht Or someone to advise me another component, please?

cagonvinon avatar Jul 11 '21 18:07 cagonvinon

I succced integrating this as a module in an angular 12+ project. Here is project. demo-select-tree.zip

cagonvinon avatar Jul 18 '21 15:07 cagonvinon

@cagonvinon this demo-select-tree working fine in angular 12+ projects but search filter is not working.

Anand-crownit avatar Mar 06 '23 08:03 Anand-crownit