ToDont icon indicating copy to clipboard operation
ToDont copied to clipboard

Published 20 hours ago • verified publisher icon Crazy-Marvin

Unable to update edit in tasks&notes with an apostrophe(')

Open ghost opened this issue 3 years ago • 11 comments

:writing_hand: Describe the bug

When a task or note with apostrophe have been edited, click on the update button, the edit will be lost rather than saved.

:bomb: Steps to reproduce

  1. Create a new task and type any content with an apostrophe.
  2. Click on save.
  3. Edit the note or task and click the update button.
  4. The edit is lost rather than saved.

:wrench: Expected behavior

The edit is saved.

:camera: Screenshots

:iphone: Tech info

  • Device: Huawei p30 pro
  • OS: EMUI10.0
  • App Version: 1.1 Beta

:page_facing_up: Additional context

ghost avatar Jul 08 '21 03:07 ghost

Hey, thanks for your bug report. The same happens on my phone too. @arafaatqureshi will have a look into it.

CrazyMarvin avatar Jul 08 '21 07:07 CrazyMarvin

Hey, thanks for your bug report. The same happens on my phone too. @arafaatqureshi will have a look into it.

Fine. Thank you. I'm looking forward to its fixing. 🙂

ghost avatar Jul 08 '21 12:07 ghost

With v1.2 this should be fixed hopefully. Please let us know if that's the case for you. Sorry for the inconvenience.

CrazyMarvin avatar Jul 16 '21 21:07 CrazyMarvin

With v1.2 this should be fixed hopefully. Please let us know if that's the case for you. Sorry for the inconvenience.

Still has the problem😅

ghost avatar Jul 29 '21 10:07 ghost

Thank you for hard work, it seems this is a complex problem😂

ghost avatar Jul 29 '21 10:07 ghost

We will have another look. Thanks for your patience. 🙏

By the way, is it possible for you to write an apostrophe in the Enter Task field and in the Note field it crashes? Or does it crash in both fields for you when entering an apostrophe?

CrazyMarvin avatar Sep 11 '21 21:09 CrazyMarvin

@CrazyMarvin We updated it last time and it was working fine then for apostrophe. Didnt check it for update again. will look into it.

arafaatqureshi avatar Sep 12 '21 07:09 arafaatqureshi

I just checked again and an apostrophe in the task itself (green circle) is working as intended on my device but a note with an apostrophe (red circle) is not saved and causes a crash sometimes.

apostrophe

CrazyMarvin avatar Dec 30 '21 21:12 CrazyMarvin

An apostrophe in a label causes a crash too.

CrazyMarvin avatar Dec 30 '21 22:12 CrazyMarvin

Does it make a difference for you if you create a label first or not? I noticed this on my device:

This crashes: Task created first, then label

This works: Label created, task afterwards

CrazyMarvin avatar Jan 24 '22 20:01 CrazyMarvin

It's quite strange , I'm still looking into it.

arafaatqureshi avatar Jan 25 '22 05:01 arafaatqureshi

@subeep, it would be awesome if you could have a look at this issue too. 😅 Thanks!

CrazyMarvin avatar Oct 04 '22 22:10 CrazyMarvin

I have solved the problem. I will pull the request as soon as I can fork the project again because of my previous pull there are many changes in my fork and once the pull merges, I can solve this by forking the updated version.

subeep avatar Oct 05 '22 12:10 subeep

I have solved the problem. I will pull the request as soon as I can fork the project again because of my previous pull there are many changes in my fork and once the pull merges, I can solve this by forking the updated version.

That are great news. I just merged your existing PR so that you can go on. 😀

CrazyMarvin avatar Oct 05 '22 14:10 CrazyMarvin

Fixed in To Don't v1.9 (closed by #165)

CrazyMarvin avatar Oct 05 '22 18:10 CrazyMarvin