SmartRedis icon indicating copy to clipboard operation
SmartRedis copied to clipboard

set_model() and set_script() return a CommandReply that is never checked for success

Open billschereriii opened this issue 2 years ago • 0 comments

Description

The set_model() and set_script() methods of the Redis and RedisCluster classes return a CommandReply that is never checked for success. This could in theory allow an error to go undetected. In practice, though, normally any errors generate exceptions.

How to reproduce

View the code

Expected behavior

A SmartRedis::RuntimeException should be generated if the CommandReply contains an error. The return type of these methods should be changed to void.

System

All

billschereriii avatar Apr 01 '22 19:04 billschereriii