Nikolai Korolev

Results 26 comments of Nikolai Korolev

@anuraghazra I've made an implementation of one of my ideas in #960 with an explanation inside PR

> Please describe the problem that this solves. You can open an issue for this. Ideally also add a test that fails without you contribution and passes with your fix....

Check this one for a similar issue: #519

Thank you for that @way2muchnoise. Really appreciate

@taoyds ygan already told about this problem in Apr 19, 2019. Please fix it.

As I didn't want to wait one more year for fixes to come I've already done everything by myself. Spider Dataset from 06/07/2020 with fixed `wta_1`: https://drive.google.com/file/d/1m68AHHPC4pqyjT-Zmt-u8TRqdw5vp-U5/view Fixed `evaluation.py` which...

You need to add extra functionality in `process_sql.py` Look for `AGG_OPS` global variable and its' usages. Functions can be implemented the same way, but you'll also need to support comma...

Yes, you should put all the functions in predefined variable. I think you can start with simply extending AGG_OPS with your function (e.g. `date_format`) but I don't guarantee you that...

Even more. `wta_1.sqlite` doesn't have table `qualifying_matches` which is in `wta_1.sql`