Rune Tynan

Results 132 comments of Rune Tynan

Thank you for your work on this! I'll merge this once I find time to review it.

I'm not worried about the coverage failure personally - a decrease of `.06` isn't really a big deal, and the clippy fixes I'm guessing just altered line hits slightly.

Upon review, this looks good to me. I'm not able to speak to the PKG_CONFIG failures right now, but the changes in this are at least necessary to fix some...

I'm afraid not - since all the fields are public, outside users could be constructing instances of the type directly, or matching fields exhaustively, and any change to its fields...

I already did the easy MSRV cleanups in #57, I'd be willing to take a look at some of the other things on the list when I have a moment....

I added a private `__non_exhaustive` field to `Library` - the error messages will be slightly worse, but this should give us the same allowances as `#[non_exhaustive]` would in most cases,...

@waych @pkgw Any updates here? This is blocking work on tectonic, and interest was expressed in making a version bump eventually. It's good to note that older projects shouldn't really...

Nevermind, I've resolved this by avoiding using `icu` in favor of a Rust encoding implementation. Will leave this PR open in case `vcpkg-rs` activity resumes.

I believe using the in-memory IO provider should allow you to drive the engine without doing any file IO. That should allow you to generate a PDF file as a...