Canvas icon indicating copy to clipboard operation
Canvas copied to clipboard

Added sentry logging implementation

Open NicklasMatzulla opened this issue 2 months ago • 7 comments

This PR adds support for Sentry logging, as requested in feature request https://github.com/CraftCanvasMC/Canvas/issues/133.

NicklasMatzulla avatar Nov 14 '25 23:11 NicklasMatzulla

Requested review, will look at this closely when I have time. Thank you for the PR

Dueris avatar Nov 14 '25 23:11 Dueris

Generally, while this does resolve that issue, we came to a conclusion that we don’t see the benefit in such a “bare” implementation, but instead prefer to have a more complete one with better debugging implemented, which I planned to implement myself but haven’t had the time to do that yet. And as this is not an urgent issue i’m not in favour of pulling this atm, if you want to however put work into this to implement more features, feel free to reach out in our discord to discuss things in more detail.

Toffikk avatar Nov 14 '25 23:11 Toffikk

Yea Toffikk is right, I honestly forgot about that conversation lol. But yea, having further debugging would be handy, otherwise I am not entirely fond of pulling this.

Dueris avatar Nov 14 '25 23:11 Dueris

I created this PR only as a quick fix to solve the current problem that errors are not being logged in Sentry. I would recommend merging the PR and improving the implementation at a later date, if time allows. I am aware that my implementation ignores many features, but my priority was to have a solution in place. After all, it's better to have something than nothing, especially if you don't have time.

NicklasMatzulla avatar Nov 15 '25 11:11 NicklasMatzulla

Sentry support however is not something that is urgent, especially given that all of the info this impl provides is also what we can from logs more easily with even more details, and sentry not being implemented isn’t something we can qualify as a problem, only as a feature request.

Toffikk avatar Nov 15 '25 14:11 Toffikk

Also i don’t think proper credits have been given here as the patch and some things seem to be taken from Luminol(?) but only mention pufferfish.

Toffikk avatar Nov 15 '25 14:11 Toffikk

For the record, a feature that would make this PR more viable would be figuring out how to attach configuration files to the sentry environment report

Toffikk avatar Nov 15 '25 19:11 Toffikk