helix-themes icon indicating copy to clipboard operation
helix-themes copied to clipboard

Use bg color to highlight diagnostics?

Open CptPotato opened this issue 3 years ago • 2 comments

I've experimented with using git diff colors to highlight LSP diagnostics in the source code, and I quite like the result:

image

@epbuennig if you don't mind, since you were somewhat involved (#7), what do you think? Does this help visibility and "look good" without being too distracting or do you prefer the background-less version?

CptPotato avatar Jan 30 '23 12:01 CptPotato

I think the background certainly helps in the cases where the underlines have the same shape. I personally don't like the style of the text having a light background on it, but that would certainly push me personally to resolve the issues quicker.

Ill have to check at home if it increases visibility on larger code snippets.

I think a style change that helps visibility is more important than over all style preference for me.

epbuennig avatar Jan 30 '23 12:01 epbuennig

Thanks for sharing your opinion.

I think I'll leave the themes in this repo unchanged for now, unless there are people who would like to see this change.

CptPotato avatar Jan 31 '23 19:01 CptPotato