countly-sdk-ios icon indicating copy to clipboard operation
countly-sdk-ios copied to clipboard

Published 20 hours ago • verified publisher icon Countly

Support dark mode

Open swifty-tim opened this issue 4 years ago • 1 comments

Expected Behavior

When showing Rating and Feedback widget, it would be nice to have dark mode support.

Current Behavior

It current just has a background color of white.

Screenshots (if appropriate):

Not really required.

Possible Solution

As the feedback view is a web view, you could load a CSS file with dark mode supported.

Steps to Reproduce (for bugs)

  1. Show the widget

More Description

I don't think any is required.

Your Environment

iOS 13.3 Xcode 11.3 Countly 19.08

  • Countly iOS SDK version
  • Your iOS version
  • Any changes you have made to this SDK

swifty-tim avatar Dec 17 '19 13:12 swifty-tim

Hi @collegboi

Nice idea. While requesting feedback widget, we can send a special flag to indicate user's dark mode preference, so server can return a modified CSS, special for dark mode.

Let me discuss this with my teammates, as this requires both design and server side work. Another approach would be just overriding CSS on the app side, but I do not think it is a good idea.

erkanyildiz avatar Jan 04 '20 16:01 erkanyildiz