countly-sdk-cpp icon indicating copy to clipboard operation
countly-sdk-cpp copied to clipboard

Published 20 hours ago • verified publisher icon Countly

why does the CMakeList check to ensure you provide a custom HTTPClient callback when building as a static library?

Open Zephilinox opened this issue 3 years ago • 4 comments
trafficstars

I assume there was some issue that caused this check to be added? I'm curious. I would have thought it would work just fine 🤔

Zephilinox avatar Jan 25 '22 18:01 Zephilinox

Which check specifically do you mean?

ArtursKadikis avatar Jan 25 '22 18:01 ArtursKadikis

sorry, I should have linked to it directly :) it's this one https://github.com/Countly/countly-sdk-cpp/blob/master/CMakeLists.txt#L16

Zephilinox avatar Jan 26 '22 16:01 Zephilinox

Hello. I'm not actually sure myself, the original developers are not part of the team anymore. After looking into git blame, it looks like they were added in this PR: https://github.com/Countly/countly-sdk-cpp/pull/16

And one of the issues it would fix is this: https://github.com/Countly/countly-sdk-cpp/issues/15

ArtursKadikis avatar Jan 26 '22 16:01 ArtursKadikis

hi :)

Hello. I'm not actually sure myself, the original developers are not part of the team anymore.

aw okay, no worries :)

#16 fixes windows by excluding it from that check, so it wasn't the original reason for the check being added (for non-windows platforms) 🤔

Zephilinox avatar Jan 26 '22 16:01 Zephilinox