countly-sdk-android icon indicating copy to clipboard operation
countly-sdk-android copied to clipboard

Gradle verify

Open hannesa2 opened this issue 4 years ago • 3 comments

This is the full story https://github.com/gradle/wrapper-validation-action#the-gradle-wrapper-problem-in-open-source

hannesa2 avatar Jul 16 '20 04:07 hannesa2

I guess you have to enable Github actions

hannesa2 avatar Jul 16 '20 04:07 hannesa2

When you enable Github actions, you will see your gradle jar file has a wrong checksum

https://github.com/hannesa2/countly-sdk-android/pull/1/checks?check_run_id=876276329

image

hannesa2 avatar Jul 16 '20 05:07 hannesa2

Now it works image

hannesa2 avatar Jul 16 '20 05:07 hannesa2

To generate and add a gradle wrapper -> https://stackoverflow.com/a/25770202

arifBurakDemiray avatar Jan 30 '24 09:01 arifBurakDemiray

@hannesa2 Thank you very much for your contribution. We will take action for it. I have updated scripts and workflow file with the most updated ones. I have also opened a new PR for fresh generated gradle-wrapper.jar for version 7.5 https://github.com/Countly/countly-sdk-android/pull/212

arifBurakDemiray avatar Jan 30 '24 09:01 arifBurakDemiray

some things to consider

Sorry to say this. After 3 (!) years of silence, my focus is now somewhere else. I work for other topics and projects now. See it as suggestion. Merge it, change it, or close it.

hannesa2 avatar Jan 30 '24 11:01 hannesa2

Hello, we merged a modified version of this. Thank you for your contribution

ArtursKadikis avatar Jan 30 '24 12:01 ArtursKadikis