web-frontend icon indicating copy to clipboard operation
web-frontend copied to clipboard

fix: add email type attribute to email input fields

Open Roshanjossey opened this issue 1 year ago • 7 comments

closes Couchers-org/couchers#4135

Web frontend checklist

  • [x] Formatted my code with make format
  • [x] There are no warnings from make lint
  • [ ] There are no console warnings when running the app
  • [ ] Added any new components to storybook
  • [ ] Added tests where relevant
  • [x] All tests pass
  • [x] Clicked around my changes running locally and it works
  • [x] Checked Desktop, Mobile and Tablet screen sizes

Roshanjossey avatar Jan 14 '24 09:01 Roshanjossey

hey! you can add me to reviewer to check the PRs (if you want it), also I wrote you in LinkedIn :)

bakeiro avatar Jan 26 '24 09:01 bakeiro

couldn't reproduce it in next neither prod https://couchers.org/password-reset, might be already solved?

bakeiro avatar Jan 26 '24 11:01 bakeiro

@bakeiro, how did you test it?

Roshanjossey avatar Feb 07 '24 13:02 Roshanjossey

@bakeiro, how did you test it?

Tried to get the branch locally but couldn't get it (not sure why) so just copied the code modifications and tried to see that the uppercase problem was solved but seems that the code changed didn't affect it. (also I saw that in production doesn't happen either the uppercase problem)

bakeiro avatar Feb 07 '24 15:02 bakeiro

I can still reproduce it on mobile. So, the bug is not that we're doing something to capitalize first letter. It's a native behaviour on input fields on mobile to show keyboard with capital letter in the beginning.

Roshanjossey avatar Feb 07 '24 16:02 Roshanjossey

I can still reproduce it on mobile. So, the bug is not that we're doing something to capitalize first letter. It's a native behaviour on input fields on mobile to show keyboard with capital letter in the beginning.

yeah yeah, that I understood, but where? every time I put the password (android or iOS) isn't capitalized by default, email yes, but not password

bakeiro avatar Feb 15 '24 11:02 bakeiro

test

keyboard it's missing in the pic 😅, but for me the first letter ISN'T capitalized by default... maybe happens in other iOS devices? if that's the case then we can merge it :)

[approved just in case]

bakeiro avatar Feb 15 '24 11:02 bakeiro