web-frontend
web-frontend copied to clipboard
fix: add email type attribute to email input fields
closes Couchers-org/couchers#4135
Web frontend checklist
- [x] Formatted my code with
make format
- [x] There are no warnings from
make lint
- [ ] There are no console warnings when running the app
- [ ] Added any new components to storybook
- [ ] Added tests where relevant
- [x] All tests pass
- [x] Clicked around my changes running locally and it works
- [x] Checked Desktop, Mobile and Tablet screen sizes
hey! you can add me to reviewer to check the PRs (if you want it), also I wrote you in LinkedIn :)
couldn't reproduce it in next neither prod https://couchers.org/password-reset, might be already solved?
@bakeiro, how did you test it?
@bakeiro, how did you test it?
Tried to get the branch locally but couldn't get it (not sure why) so just copied the code modifications and tried to see that the uppercase problem was solved but seems that the code changed didn't affect it. (also I saw that in production doesn't happen either the uppercase problem)
I can still reproduce it on mobile. So, the bug is not that we're doing something to capitalize first letter. It's a native behaviour on input fields on mobile to show keyboard with capital letter in the beginning.
I can still reproduce it on mobile. So, the bug is not that we're doing something to capitalize first letter. It's a native behaviour on input fields on mobile to show keyboard with capital letter in the beginning.
yeah yeah, that I understood, but where? every time I put the password (android or iOS) isn't capitalized by default, email yes, but not password
keyboard it's missing in the pic 😅, but for me the first letter ISN'T capitalized by default... maybe happens in other iOS devices? if that's the case then we can merge it :)
[approved just in case]