magento-composer-installer icon indicating copy to clipboard operation
magento-composer-installer copied to clipboard

magento-deploy-ignore not ignoring folders/files

Open proxium opened this issue 10 years ago • 6 comments

As @AydinHassan suggested, this is an update:

I'm using "magento-hackathon/magento-composer-installer": "3.0.5" and none of these solved the problem.

  • Using package name

        "magento-deploy-ignore": {
            "kirchbergerknorr/magento": ["/skin/frontend/base/default/favicon.ico"],
            "kirchbergerknorr/magento": ["/downloader/"]
        },
    
  • Using asterisk

        "magento-deploy-ignore": {
            "*": ["/skin/frontend/base/default/favicon.ico"],
            "*": ["/downloader/"]
        },
    
  • Removing leading slash

        "magento-deploy-ignore": {
            "kirchbergerknorr/magento": ["skin/frontend/base/default/favicon.ico"],
            "kirchbergerknorr/magento": ["downloader/"]
        },
    

proxium avatar Sep 11 '15 12:09 proxium

Works:

"magento-deploy-ignore": { "test/module": [ "/app/locale/de_DE/Test_Module.csv", "/app/locale/es_ES/Test_Module.csv" ], "test/module2": [ "/app/locale/de_DE/Test_Module2.csv", "/app/locale/de_AT/Test_Module2.csv" ] }

cs-digitalpatrioten avatar Oct 07 '16 11:10 cs-digitalpatrioten

Now I'm using "magento-hakathon/magento-composer-installer":"3.0.7" and I'm still not able to ignore those two resources (favicon.ico and /downloader/ folder)

Here is the used syntax:

 "extra": {
        "magento-root-dir": "src/",
        "with-bootstrap-patch": false,
        "skip-suggest-repositories": true,
        "auto-append-gitignore": true,
        "magento-deploystrategy": "copy",
        "magento-force": true,
        "magento-deploy-sort-priority": {
            "firegento/magento": "100"
        },
        "magento-deploy-ignore": {
            "firegento/magento": ["/skin/frontend/base/default/favicon.ico"],
            "firegento/magento": ["/downloader/"]
        }
    }

proxium avatar Oct 13 '16 14:10 proxium

@proxium firegento/magento is not a magento module - this plugin does not touch that package at all as it's type is magento-core not magento-module.

AydinHassan avatar Oct 13 '16 14:10 AydinHassan

@AydinHassan should I report this issue here ? https://github.com/AydinHassan/magento-core-composer-installer/issues

proxium avatar Feb 23 '17 15:02 proxium

Same problem. "magento-hackathon/magento-composer-installer": "3.1.2". "magento-deploy-ignore": { "*": ["/.htaccess"], "magento/core": ["/.htacces"] }

File still overrides

krombox avatar Nov 15 '17 12:11 krombox

@krombox the installer can sadly only ignore files, which come from magento modules. if its source is a magento core project, then it is not handling the deploy, and therefore cant ignore it.

Flyingmana avatar Nov 20 '17 08:11 Flyingmana