magento-composer-installer icon indicating copy to clipboard operation
magento-composer-installer copied to clipboard

deploy strategy link doesn't add / remove files to magento-root-dir/.gitignore and doesn't remove files from disk on composer remove package/x

Open branb opened this issue 8 years ago • 3 comments

As the title says, with deploy strategy link (e.g. hard links), upon issuing composer require package/x, sometimes no files or just some files are added to magento-root-dir/.gitignore.

Also, when issuing composer remove package/x, files are also not removed from the magento-root-dir either.

I tested this with various extensions and with my own extension, which only had 4 files. For my own extension, no files were added to .gitignore at all and in the case of the tested extensions from the firegento repo some files were missing from the .gitignore, most of the time files that are not in app/code/, e.g. files in skin/ or app/design/* etc.

Tested extensions were for example:

  • "aoepeople/aoe_scheduler": "^1.5" or
  • "connect20/ASchroder_SMTPPro": "^2.0"

Only changing the deploy strategy to something like symlink "fixes" this, e.g. .gitignore is populated as expected and files are deleted on composer remove as well.

branb avatar Aug 08 '17 13:08 branb

@branb I can reproduce this!

hhirsch avatar May 04 '18 12:05 hhirsch

@hhirsch Did you experience this with a custom extension or with one from a public repository?

branb avatar May 04 '18 12:05 branb

@branb I've rolled these myself. I am sure it is for every package.

hhirsch avatar May 04 '18 12:05 hhirsch