juno icon indicating copy to clipboard operation
juno copied to clipboard

ibc v3.1.1 sdk 457, tm 3420

Open faddat opened this issue 2 years ago • 4 comments

@the-frey, @JakeHartnell and I have talked a great deal about making faster, incremental releases.

So here's juno but more special:

  • tendermint v0.34.20
  • ibc-go v3.1.1
  • cosmos-sdk v0.45.7
  • iavl v0.19.1

All of these put together make for a leaner, meaner juno.

Deploy plan

This is a state breaking change because of ibc-go v3.1.1. It should be tested on Uni first.

Deploy timeline

We should play around and see how quickly (or not) we can get this out. The changes are in total quite minor, though they should make juno a good deal faster.

faddat avatar Aug 10 '22 00:08 faddat

@faddat i saw some cosmos repos already using ibc go v4(alpha), any estimation if that would introduce breaking changes again? Will check the diff of v3v4 later today

sascha1337 avatar Aug 10 '22 06:08 sascha1337

definitely agree wiht your changes @the-frey

faddat avatar Aug 14 '22 15:08 faddat

https://github.com/CosmWasm/wasmd/pull/937

faddat avatar Aug 14 '22 15:08 faddat

  • @JakeHartnell @joeabbey @the-frey hey fyi -- this requireshttps://github.com/CosmWasm/wasmd/pull/940 to be merged upstream.

faddat avatar Aug 14 '22 15:08 faddat

🔥

  • https://github.com/CosmWasm/wasmd/pull/940

many thanks to Mr. David, another upstream swimmer, for

  • https://github.com/CosmWasm/wasmd/pull/919

faddat avatar Aug 15 '22 10:08 faddat

Changes look good, I'm just getting caught up now I'm back at my desk. I guess we want to test the blocks/inflation test first and then get this up on uni. Maybe that order.

the-frey avatar Aug 18 '22 08:08 the-frey

yeah, so I think that this PR should be merged and referred to as the base of Juno v10

Agree that we should do the inflation thing, which likely reqires a gov prop.

Are you referring to the suggestion about making it linear instead of steps, or something else?

Also, this is honestly held up on

  • https://github.com/CosmWasm/wasmd/issues/941

and

  • https://github.com/CosmWasm/wasmd/pull/940

My preference is to merge this, then:

  • deal with the block timing/emissions issue
  • Hope that https://github.com/CosmWasm/wasmd/pull/940 is merged, or another solution is worked out

faddat avatar Aug 21 '22 15:08 faddat

That's the idea -- also since I figure that Juno is best off as a reference implementation of wasmd, we've also made a wasmd branch based from osmosis-- afaik unfinished.

faddat avatar Aug 25 '22 09:08 faddat

Latest bump brought us current with this wasmd branch:

  • https://github.com/CosmWasm/wasmd/pull/940

faddat avatar Aug 25 '22 14:08 faddat

Modified superlinter.yml so that we don't check over go code twice.

faddat avatar Aug 25 '22 15:08 faddat

FYI: this could easily be superceded by:

https://github.com/CosmosContracts/juno/pull/270

They're now both in the same state in that for both PR's we are relying on a Notional fork of wasmd

faddat avatar Aug 25 '22 16:08 faddat

FYI: this could easily be superceded by:

#270

They're now both in the same state in that for both PR's we are relying on a Notional fork of wasmd

I'd stick with SDK 45 for now, what do you think @JakeHartnell @the-frey ?

dimiandre avatar Aug 25 '22 19:08 dimiandre

given events of the past few hours, fully agree @dimiandre

Much better to stick with the 45 series.

faddat avatar Aug 25 '22 21:08 faddat

Yep stick with 45

the-frey avatar Aug 26 '22 09:08 the-frey

Leaving a note for self here: version 10 is not ready for production until we can revert to mainline wasmd

the-frey avatar Aug 30 '22 09:08 the-frey