Motion icon indicating copy to clipboard operation
Motion copied to clipboard

Motion affects other 3-rd party animation libraries

Open roteirod opened this issue 6 years ago • 9 comments

Hi there! First of all, I want to say that I love Motion a lot, it is a great thing which allows developers to do awesome stuff in their apps. I want to use it in our project a lot, but I am currently having several issues, and I would like to help finding and fixing them...

Along with Motion, I am using NVActivityIndicatorView, and I noticed that after several Motion transitions, my NVActivityIndicatorView animations work with some delay, and the more Motion transitions I perform, the worse it gets for NVActivityIndicatorView. Here is a video of a simple project I made. I tap "Animation" button to trigger NVActivityIndicatorView animation, it works fine. Then I do 10 Motion transitions and tap "Animation" again. You can see a slight freeze/delay. I repeat it 2 more times and it gets worse with every 10 transitions. In my real app with more complex views and transitions this thing is noticeable even after 2-3 transitions

video.mp4.zip tabbarissue.zip

I discovered that HeroTransitions has the same issue: https://github.com/HeroTransitions/Hero/issues/256 And it happens not only with NVActivityIndicatorView but with other libraries too as you can see in that discussion

roteirod avatar Sep 10 '19 09:09 roteirod

Hey! Thank you for the issue! I've checked the both Motion and NVActivityIndicatorView sources (not tried your app, do not have proper xcode right now). I have no clue what happens there that causes lag in our side.

In the Hero issue you linked, someone posted that beginTime = CACurrentMediaTime() causes issue. Can you try . ballClipRotatePulse animation in your NVActivityIndicatorView? It does not use set beginTime = CACurrentMediaTime()

OrkhanAlikhanov avatar Sep 10 '19 11:09 OrkhanAlikhanov

It acts the same with . ballClipRotatePulse...

roteirod avatar Sep 10 '19 11:09 roteirod

@roteirod This will take some time to solve. I will setup a workspace with NVActivityIndicatorView shortly.

adamdahan avatar Sep 11 '19 16:09 adamdahan

@roteirod This will take some time to solve. I will setup a workspace with NVActivityIndicatorView shortly.

Hey! Do you have some update on the issue? Can't wait to start using your library in our app.. :)

roteirod avatar Sep 23 '19 12:09 roteirod

Hi @roteirod looking at this today. Sorry for any delays.

daniel-jonathan avatar Sep 23 '19 14:09 daniel-jonathan

Hey, guys! Any progress on this issue?

roteirod avatar Oct 17 '19 09:10 roteirod

@roteirod Hey, sorry no, there hasn't been any progress. We have been so busy with other work, that we haven't had a chance to look into this.

daniel-jonathan avatar Oct 17 '19 15:10 daniel-jonathan

@roteirod Hey, sorry no, there hasn't been any progress. We have been so busy with other work, that we haven't had a chance to look into this.

Ok... Let me know when you look into it

roteirod avatar Oct 18 '19 07:10 roteirod

Is this issue resolved ? I am looking for a library that doesn't breaks other animation libraries.

amit2908 avatar May 22 '20 04:05 amit2908