Material icon indicating copy to clipboard operation
Material copied to clipboard

Pulse animation stuck

Open gedzionsas opened this issue 7 years ago • 4 comments

Hi, I got problem with pulse animation, when I press on button and swipe to next controller with UIViewControllerAnimatedTransitioning, after that I get back to controller with button and pulse animation is stucked because touchesCancelled not called, could you help me with that?

gedzionsas avatar Oct 24 '18 08:10 gedzionsas

Hey! To be honest, I did experience that somehow, but was never able to find steps to reproduce it, can you share a sample project replicating the issue?

OrkhanAlikhanov avatar Oct 24 '18 14:10 OrkhanAlikhanov

Hey! I think this is because of the touch event to shrink the pulse is not fired when there is a swipe. @OrkhanAlikhanov I think we can set a timer on the pulse if the user hasn't released it, or we can look for when the button is offscreen, no longer being rendered, and update the animation lifecycle. These are some quick ideas as I think about this issue.

daniel-jonathan avatar Oct 24 '18 15:10 daniel-jonathan

Yes, it's completed because touchesCancelled not fired, I believe that detecting when button offscreen would help.

gedzionsas avatar Oct 29 '18 07:10 gedzionsas

@OrkhanAlikhanov let's discuss this in Slack, @gedzionsas if you would like to join our #opensource slack channel, please send us your email at [email protected]. I will leave this issue up until we resolve it. Thank you!

daniel-jonathan avatar Oct 29 '18 17:10 daniel-jonathan