solaris
solaris copied to clipboard
Fix tiling issue in raster_tile.py
Description
Raster tiler is missing a few tiles while creating the chips. Rounding the profile["transform"]
to 3 decimal places is creating the issue of chips overwrite, changing this to 6 decimal places fixes the issue.
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
Checklist:
- [x] My PR has a descriptive title
- [x] My code follows PEP8
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new errors
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] My PR passes Travis CI tests
- [x] My PR does not reduce coverage in Codecov
If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.
@rbavery I was able to reproduce the test errors locally.
The array values are different for tiles in
- tests/data/rastertile_test_fill_nodata_expected/
- tests/data/rastertile_test_fill_nodata_result/
Visually they look similar but array values are different.
eg:
We are just changing the precision for file names, everything else remains the same. Is it because we changed from
- opencv-python>=4.1
+ opencv>=4.5.5
@srmsoumya looking at your recent commit and just a heads up, using opencv
appears to be what works for recent releases so I think we should stick to that. See https://github.com/CosmiQ/solaris/issues/461