marshall

does the dimension levels exist?

Has this been tested? According to [the documentation](https://discord.com/developers/docs/resources/channel#allowed-mentions-object), this implementation is incorrect the `parse` array key contains data types needing to be parsed by discord... This can be `roles`, `users`...

I still think it's better to implement the actual API's class instead of relying on undocumented behavior 🤔

Perhaps include tests and some sample code into README.md Looks good to me, just needs documentation and tests

```php public function onSneak(PlayerToggleSneakEvent $ev): void { $p = $ev->getPlayer(); $p->getNetworkProperties()->setGenericFlag(EntityMetadataFlags::BLOCKING, $ev->isSneaking()); $p->getOffHandInventory()->setItem(0, ItemFactory::getInstance()->get(ItemIds::SHIELD)); } public function onAirClick(PlayerItemUseEvent $ev): void { $ev->getPlayer()->getNetworkProperties()->setGenericFlag(EntityMetadataFlags::BLOCKING, false); $this->getScheduler()->scheduleDelayedTask(new ClosureTask( fn() => $ev->getPlayer()->getNetworkProperties()->setGenericFlag(EntityMetadataFlags::BLOCKING, true) ),...

A stupid thing with enums is that it's all global, plugins could have colliding enum names and Commando intends to be used with public plugins as well #blameMojang On Wed,...

In that case there should be guidelines on how to format the enum names to prevent collisions in general use cases. This would help with plugin developers in preventing unintended...

Wouldn't the plugin name be too long sometimes? On Thu, Apr 30, 2020, 06:41 XenialDan wrote: > Or register enums with a plugin-name prefix maybe? Similar to commands in >...

> How about if we make it mandatory to supply fallback prefix and then only use it when two enum names collide? Would be a BC-Breaking change but that would...

An issue is because of how Virions are injected, the namespaces are changing. Therefore using a singleton to track the enum names that have been used would be ineffective on...