cv4pve-barc
cv4pve-barc copied to clipboard
snapshot housekeeping dies on missing snapshot - why?
If the barc snapshot is missing from the RBD, it aborts. who would want that functionality?
consider the current code:
#Snapshot Housekeeping..
#find last snapshot in ceph
latest_snap=$(rbd snap ls "$image_spec" | \
awk '{print $2}' | \
grep "$opt_label" | sort -r | head -n 1)
#not exist snapshot on rbd
if [ -z "$latest_snap" ]; then
log error "VM $vm_id - Ceph last snapshot '$image_spec' not found!";
call_hook_script "export-diff-abort" "-" "-"
rc=30
break;
fi
We want to backup this VM/disk... the snapshot is merely a means to an end. If it's missing, forget about it, create a new one, and do a new run with renew=0....?
THis is to protect you from a broken incremental snapshot chain in your backups.
I have plans to auto-fix this, eg make a full backup if the Snap is missing. Currently the sanity of the Backupchain has to be taken care of manually.
Thank you, looking forward to an update