cv4pve-barc icon indicating copy to clipboard operation
cv4pve-barc copied to clipboard

[Discussion] Remove Snapshot merging / legacy Code?

Open lephisto opened this issue 5 years ago • 6 comments

Since there are currently two approaches in the Codebase, I want to discuss if you want to keep the ability to merge snapshots into each other. I personally wouldn't dare to go on and take one Base Snapshot in a year, and then only merge onto it. And: There's no way to merge into the Basecopy, so the volatile data would accumulate in the first Differential file after the Basecopy.

lephisto avatar Jan 31 '20 22:01 lephisto

what do you propose?

franklupo avatar Jan 31 '20 23:01 franklupo

Add option --disable-merge-snapshot to disable merge.

franklupo avatar Feb 01 '20 11:02 franklupo

There's no need to do, because it won't merge snapshots in --renew mode. in --keep mode it does behave like it always did.

lephisto avatar Feb 01 '20 12:02 lephisto

What idea do you have for this?

franklupo avatar Feb 09 '20 16:02 franklupo

The idea was to compeltely remove all merge logic since it you might not detect if something goes wrong until you try to restore stuff. For now let's keep it in, and keep backwards compatibility..

lephisto avatar Feb 13 '20 23:02 lephisto

Ok for me good idea remove all merge logic

franklupo avatar Feb 14 '20 09:02 franklupo