modelkit

modelkit copied to clipboard

MRO is not respected in the class `Asset`

1

The current code suffers from a method resolution order (MRO) issue. In the `Asset` class, the `__init__` method does not call `super().__init__()`, resulting in an incorrect MRO. This omission prevents...

llin17

After diving into the code, modelkit lists the following regex for asset names: ```python3 GENERIC_ASSET_NAME_RE = ( r"(([A-Z]:\\)|/)?[a-zA-Z0-9]([a-zA-Z0-9\-\_\.\/\\]*[a-zA-Z0-9])?" ) ``` However: 1. uploaded assets and sub-files are not checked against...

nmichlo

It would help reducing the number of dependencies

tbascoul

Sometimes it makes sense to group helper utilities together in in the library search path. However, we don't always want these files to be loaded if for example the model...

nmichlo