modelkit

modelkit copied to clipboard

tbascoul

test_simple_profiler is not idempotent see [PR failure due to this](https://github.com/Cornerstone-OnDemand/modelkit/runs/6969295952?check_suite_focus=true) > =================================== FAILURES =================================== > > > _____________________________ test_simple_profiler _____________________________ > > Traceback (most recent call last): > > File...

tbascoul

If 2 models have the same configuration name, `modelkit` will silently use one of them. It should at least warn the user but maybe we just want to raise an...

tgenin

WIP: Split assets requirements

3

Here I split assets requirements in three: `modelkit[assets-s3]`, `modelkit[assets-gcs]`, and `modelkit[assets-az]` Installing `modelkit` (without any option) will _not_ install any assets driver (so only works with local assets). What do...

victorbenichoux

Having both is confusing. I don't see why a single one wouldn't be enough

CyrilLeMat

Currently breaking a prediction_batch example, breaks the call and raise the error we may want another option like (for example) returning all the batches returns except the breaking ones (set...

tgenin

The describe functions (for a library or a method) are not in the documentation. We should add them

CyrilLeMat

We don't only support gcs, we need to add s3 and azure

CyrilLeMat

Currently `asset new` or `asset update` push data from local to `MODELKIT_STORAGE_PROVIDER` https://cornerstone-ondemand.github.io/modelkit/assets/managing_assets/#create-a-new-asset which mean asset must be on local storage to be pushed It could be interesting to be...

tgenin

For models using pydantic, the describe method only display the name of the pydantic class:  Printing the content of these classes would make the model usage way easier

CyrilLeMat