Add to favorites from inside a tool

[ajpanton]

Describe the bug

When viewing the grid of tools, you can click the heart to add a tool to your favorites. This works fine.

When opening a tool, there's the heart again in the upper-right corner. Here the heart does nothing.

What happened?

Nothing happens. I expected it to be added to my favorites. Similarly, if a tool is already in the favorites, clicking this heart doesn't remove it.

System information

Docker container, very vanilla settings, just a port mapping.

Where did you encounter the bug?

A self hosted

[gitmotion]

@ajpanton this should be fixed here: https://github.com/CorentinTh/it-tools/pull/1368

and it's working in it-tools.tech - by any chance have you pulled/redeployed with the latest version? you may need to clear cache and hard reload (ctrl + shift + r) after redeploying

[ajpanton]

This was with a completely fresh container, installed for the first time with no opportunities to get screwed up over time. But I recreated it again with :latest (same as before), destroying all data it might have stored somewhere, and the problem still persists.

Since I'm using Portainer, I can't (I think) see exactly what command it uses to create a container. So I tried creating a stack (Docker Compose):

services:
    it-tools:
        image: corentinth/it-tools:latest
        container_name: it-tools
        ports:
            - '8080:80'

No change.

[gitmotion]

@ajpanton ah interesting, in that case you might want to try the nightly github package/image that should have all the newest changes: ghcr.io/corentinth/it-tools:nightly

services:
    it-tools:
        image: 'ghcr.io/corentinth/it-tools:nightly'
        container_name: it-tools
        restart: unless-stopped
        ports:
            - '8080:80'

[ajpanton]

The nightly works, thanks! Well, it's not a feature I need, as I was able to work around it. Just wanted to report a bug (that apparently is already getting fixed).

[sharevb]

Hi @ajpanton @gitmotion , it should work in my fork

And if you are interested in an up to date version of it-tools, with many improvements, new tools, and bug fixes, as this repo is almost no more maintained, I made a fork here : https://github.com/sharevb/it-tools (https://sharevb-it-tools.vercel.app/ and docker images https://github.com/sharevb/it-tools/pkgs/container/it-tools)