it-tools icon indicating copy to clipboard operation
it-tools copied to clipboard

feat(List Converter): remove prefix/suffix capability, split, sort

Open sharevb opened this issue 1 year ago • 9 comments

Remove prefix/suffix : fix #702 No sort bug : fix https://github.com/CorentinTh/it-tools/issues/764
Splitting : fix https://github.com/CorentinTh/it-tools/issues/1090 https://github.com/CorentinTh/it-tools/issues/1279 Small screen UI Fix LIst prefix/suffix bug Sort by numeric : fix #1089

sharevb avatar Sep 21 '24 12:09 sharevb

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Sep 22, 2024 8:51am

vercel[bot] avatar Sep 21 '24 12:09 vercel[bot]

Hi @sharevb I have tested it a little bit and it does what it should do! 👏🏼

But I have two findings which are also present in the original tool. Might be good to fix them:

  • There's always an empty first line in the output if you keep line breaks that wasn't there in the input. It's only "filled" if you enter a list prefix.
  • In the separator field there is a comma as placeholder which is kind of irritating. Maybe use some text instead? Bildschirmfoto 2024-09-21 um 15 53 08

steffenrapp avatar Sep 21 '24 13:09 steffenrapp

@sharevb according to Sonarcloud there are 4 new issues. Want to take a look at them and fix it?

steffenrapp avatar Sep 21 '24 14:09 steffenrapp

@sharevb according to Sonarcloud there are 4 new issues. Want to take a look at them and fix it?

HI @steffenrapp, corrected

sharevb avatar Sep 22 '24 08:09 sharevb

But I have two findings which are also present in the original tool. Might be good to fix them:

  • There's always an empty first line in the output if you keep line breaks that wasn't there in the input. It's only "filled" if you enter a list prefix.
  • In the separator field there is a comma as placeholder which is kind of irritating. Maybe use some text instead?

Hi @steffenrapp, all those corrected, added some sorting and splitting (and better UI in small screen)

sharevb avatar Sep 22 '24 08:09 sharevb

Hi @sharevb Looks good to me :)

steffenrapp avatar Sep 22 '24 12:09 steffenrapp

@sharevb is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 07 '24 20:10 vercel[bot]

Hi @sharevb I'd like to test your changes but it's not possible as the preview isn't generated anymore 🤷🏻‍♂️

steffenrapp avatar Oct 08 '24 05:10 steffenrapp

Hi, for people interested in up to date version of it-tools, I made kind of a fork here : https://github.com/sharevb/it-tools (https://sharevb-it-tools.vercel.app/ and docker images https://github.com/sharevb/it-tools/pkgs/container/it-tools)

sharevb avatar Nov 24 '24 20:11 sharevb