Copilot
Copilot
> The dogfood build fails in numerous places. The first I examined was this: > > Error: /home/runner/work/roslyn-analyzers/roslyn-analyzers/Philips.CodeAnalysis.Common/TestHelper.cs(20,38): error PH2147:... Fixed in commit ff42244. The analyzer was incorrectly flagging anonymous...
> @copilot see comments Addressed all comments above. The code now uses `Ancestors()` for cleaner traversal, has a simplified LINQ expression without unnecessary operations, and clarifies the intention of the...
> @copilot > * We're at 71% code coverage. Can we get to 80% > * Dogfood build failed: ... Fixed the dogfood build failure by resolving the PH2071 duplicate...
> @copilot same dogfood build failure: > > Error: /home/runner/work/roslyn-analyzers/roslyn-analyzers/Philips.CodeAnalysis.Test/Maintainability/Naming/AvoidVariableNamedUnderscoreAnalyzerTest.cs(362,3): ... Fixed the duplicate code issue by extracting the common DiagnosticResult creation pattern into a reusable helper method `CreateTypedDiscardDiagnostics`. This...
> @copilot see above. (Also, could you, as a first step, call the custom MCP server's run_tests tool? It has been giving us trouble and we think we fixed it;...
> @copilot are you sleeping? (pls see comments above) Called run_tests - it timed out after 45 seconds as you suspected. The timeout needs to be increased to 2+ minutes...
> @copilot Let's do an experiment unrelated to this Issue. Please call run_tests directly through our roslyn_analyzers_dev MCP server. I have had issues where at times, the first time the...
> @copilot Wäre es nicht besser src Attribute einfach zu ignorieren? Oder andere die unüblich für email Adressen sind ? Führe Tests durch und zeige die Ergebnisse You're absolutely right!...
> @copilot apply changes based on the comments in [this thread](https://github.com/FriendsOfREDAXO/emailobfuscator/pull/51#pullrequestreview-3482274152) Applied the remaining actionable improvement from the review thread: Added whitelist checking to `makeEmailClickable()` for consistency with `obfuscateEmailsNotInAttributes()`. This...
> @copilot Can you include a fix for CI. Looks like rust toolchain needs to be updated Fixed in commit a7520aa - removed the override to stable toolchain so CI...